- style
Completed Feedback
- Femi
Completed feedback and suggestions
Please add any comments and suggestions below:
Status | Feedback | Suggestion | Commenter | Response |
|---|---|---|---|---|
Done | Slider issue - we are using a slider on AQM UI and we noticed that the slider designs in Figma LUX library and in Zeplin aren’t the same. |  
| @Ori Cohen | Hi @Ori Cohen, the correct slider variants have been added to the component set now - feel free to have a look 😊. In response to the slider without ‘ticks' request, a nice temporary solution could be to toggle these off in the layers tab to hide them on the canvas. |
Done |
| Add OOTB interactive capabilities to the components e.g. hover state changes for buttons and click actions for toggles, checkboxes etc | @Femi | Has been added to the component library |
Done |
| Text in dropdown should be auto width | @Asaf Ben-Oved @Ethan McGonigle (Unlicensed) | Hi @Asaf Ben-Oved, this should now be resolved, if you’d like to take a look. |
Done | Checkbox & Radio Button | add the option to add text to a checkbox within the component. | @Omer.Glazer (Unlicensed) | Hi @Omer.Glazer (Unlicensed), the option to add text should be available for both checkboxes and radio buttons now. |
Done | Dropdown | Removing menu items doesn’t auto resize the menu containers height | @Femi | @Femi, as discussed, this issue should now be resolved and published. |
Done | Text link - see image
|
| @Asaf Ben-Oved | @Asaf Ben-Oved, as discussed, this should now be resolved and published. |
Done | I tried to make a color change to the icon, but I saw this, maybe its OK and maybe not.
| Make a simpler hierarchy? | @Asaf Ben-Oved | @Asaf Ben-Oved , not sure why it happend to you, but all the icons in the library have only a component wrapper, make sure its an icon from the library and not one of yours Asaf: Yes this is my bad - Thanks |
Done |
| States are not declared correctly? | @Asaf Ben-Oved | @Asaf Ben-Oved, I noticed the name of the component in use in your screenshot was ‘Drop-down Menu’, shown in the properties pane on the right. This must be an old component/version of the dropdown menu. The most up-to-date component is called ‘Dropdown Menu', as shown below. Perhaps a sync on your end will pull this through? |
Done |
| Should tabs dynamically resize based on the tab’s text label?
Also, responsive tab design in current documentation is different to Zeplin designs. | @Ethan McGonigle (Unlicensed) | First level tabs extend to the entire containing container 2nd level are sized per tab |
Done | Tryng to shorten the width of a list doesn’t change the rows
| Make rows resized according to main frame | @Asaf Ben-Oved | @Asaf Ben-Oved this is fixed now |
Done | Changing the text in the list also change the text I already input
| Changing states should not overwrite the text | @Asaf Ben-Oved | @Yehiel Elad-Certner (Unlicensed) looking at fix |
Done | No asset for dialog and wizard | Add these assets | @Ayelet Servi | @Yehiel Elad-Certner (Unlicensed) working on it |
Done | The stroke for the text field and for the dropdown is of a different color | Change so they have the same color | @Ayelet Servi | @Yehiel Elad-Certner (Unlicensed) working on it |
Done | Cant find a recycle bin icon | Add | @Ayelet Servi | @Ayelet Servi Icon is called ‘Trash’ in the library |
Done | Toggle (switch) - Looks to me a bit too large (compared to the radio button for example like you can see in the image here). Is it me or do you also think we should make it smaller? |
| @Ayelet Servi | @Ayelet Servi That is correct, the currently implemented toggle is the default base toggle size - https://app.zeplin.io/project/5970b366bee38cf87b2de932/screen/60215bfbe9271d153359f985 I’ll add the small toggle variant (https://app.zeplin.io/project/5970b366bee38cf87b2de932/screen/60f7c70930286e161ee453dd ) to the schedule. |
Done | The Speaker icon - I think that we should consider changing its name in the asset to Audio (Since that’s what it represents in our products) | Change icon’s name | @Ayelet Servi | @Ayelet Servi The icon is already in use in various applications under that name hence Guy doesn’t think it would be worth renaming as it will create technical issues. @Femi OK, thanks |
Done | The gap between a radio button and a label should be 6px? at least from what I saw in Zeplin. This is it looks currently
| Change the gap from 10px to 6px.
| @Asaf Ben-Oved | Hi @Asaf Ben-Oved, this has been updated 👍 |
Done | See feedback within the movie
|
| @Asaf Ben-Oved | Hi @Asaf Ben-Oved, tooltips have been updated to allow users to manually adjust the width. Removing the gap between the tooltip component and purple selection box was not possible in variants that show the top arrows, since these elements use absolute positioning (which allows us to achieve the visual design where the pointed arrow cuts into the tooltip’s stroke). Where possible, the relevant variants have also been updated so there is no gap between the tooltip and the selection box. |
Done | In the assets - can’t find a toast message (although it appears as “done”) | Add the toast. Thanks | @Ayelet Servi | @Ayelet Servi It should now be published and available |
Done | The current watermark is only set to be used on top-right corner. There are times when we need it on a different corner since that corner has some functionality that need demonstration. | Make the watermark adjustable for all 4 corners of the screen | @Asaf Ben-Oved | Done. |
Done | Different disabled styling between a dialog button and a split button | Align the styles | @Asaf Ben-Oved | @Asaf Ben-Oved done. |
Done | I’m missing an orange warning icon (I see only a gray one). Need it for inline messages. | Add to the assets | @Ayelet Servi | @Ayelet Servi All icons come in the default grey out of the box. Once on the canvas you can change the icons color in the ‘Selection colors’ section of Figma’s design tab @Femi That’s what I did, but since each type has one appropriate color only, isn’t it better that we have the colored ones already ready in our assets? Also, do you know when we are supposed to use the gray ones and when the colored? @Ayelet Servi The icons themselves are all created as vector icons in exactly the same format so that they can be resized and recolored by the designer depending on their desired purpose (as the same icon may be used or colored in different ways). When we have components that make use of a specific icon asset (e.g. Tooltips, icon buttons etc), the icon is styled accordingly within the component itself. @Femi OK, thanks Femi |
Done | This icon is called “Folders” in the assets | Should be called “Open folder” | @Ayelet Servi | Hi @Ayelet Servi, this icon is already in use under the same name in various applications, so we don’t think it would be worth renaming it due to the technical issues it would cause. |
Done | Icon buttons with a label - the frame doesn’t adjust to the label text | Auto-adjust the frame to fit the label. Otherwise it causes a problem in auto-layout. (But not a big problem to fix manually). | @Carlie Bradshaw | Hi @Carlie Bradshaw, this has been fixed. |
Done | Popup has fixed width buttons | Have to detach for buttons which aren’t short single words. (Lots of examples in the common messages repository, e.g. keep editing/leave anyway). | @Carlie Bradshaw | Hi @Carlie Bradshaw, these buttons have been updated to hug contents 😊 |
Done | Missing canvas section. This is needed in order to organize the canvas space. Also these sections should have a big enough font to be able to see while you are zoomed out | see example
| @Asaf Ben-Oved | @Ori Cohen Done. |
Done | Removing icon from a tree list item doesn’t align label to the left, as it does in a normal list |
| @Carlie Bradshaw | Hi @Carlie Bradshaw, this seems to be working now, would you mind checking again to see if it is on your end as well? Hey @Femi , it’s these ones which are causing the problem: Hi @Carlie Bradshaw, the tree component has been updated and published - these issues should be fixed now 😊. |
Done | Date picker menu should start from Sunday and not Monday
| Set the date picker menu to start from Sunday | @Asaf Ben-Oved | Hi @Asaf Ben-Oved, this seems to have already been updated so the week starts from Sunday. For other calendars (with weeks that start on Monday), is it reasonable to expect designers to update this manually? |
Done | Hover state of a cell in the date picker menu is incorrect
| From the LUX wiki page. Hover is used as a stroke not a font color
| @Asaf Ben-Oved | Hi @Asaf Ben-Oved, this has been updated with the correct visual design. |
Done | Resizing the Canvas title doesn’t adapt the background color
| Allow the background to also resize | @Asaf Ben-Oved | Was fixed by @Ori Cohen |
Done | In tooltip the “Plain text” and “Header” should be under the Type menu and not the State menu
| Put header and Plain text under the Type menu | @Asaf Ben-Oved | Hi @Asaf Ben-Oved, the tooltip properties have been updated 😊 |
Done | Inconsistency in changing menu width when done from action menu - width changes by text in dropdown - width changes by manually change
| change the width both “hugging” and by manual pull | @Asaf Ben-Oved | Hi @Asaf Ben-Oved, it was Guy’s request to have all menus that are connected to input fields to be the same width as the field, hence the manual resize for the dropdown menu component. Since we would want the icon above the action menu to be a fixed width, we allow users to dictate the width of the dropdown menu here with the list item label instead. So, although these behaviours are different they are both intentional and considered appropriate for the reasons above.
|
Done | A time picker in a disabled state still has the icon in it shows as in regular state
| The design is | @Asaf Ben-Oved | Hi @Asaf Ben-Oved, the icon has been updated. |
Done | Missing “Clear” icon for the search field (or the search field state that includes this icon). | Add | @Ayelet Servi | Hi @Ayelet Servi, the ‘clear’ icon should be visible in the search field when the ‘filled’ type is selected. |
Done | There’s a bug with the dropdown list: Before run - The texts of the options appear as they shoud:
When running - The texts sometimes (might be related to making it active) go back to their default:
|
| @Ayelet Servi | Hi @Ayelet Servi, we ran a lot of tests to try to fix this but unfortunately had no luck - we believe it’s a bug in Figma’s presentation mode. Sometimes refreshing the prototype seems to resolve this issue, but other times the text does reset to it’s default label.
|
Done | Missing a state in toast where its a warning and also has the expand/collapse |
| @Asaf Ben-Oved | Hi @Asaf Ben-Oved, these variants have been added 👍 |
Done | Cannot put a storke on bottom part of of the list - see image | Allow full stroke for a list | @Asaf Ben-Oved | Hi @Asaf Ben-Oved, this should be fixed now. |
Done | Selected state in Menu seems not to be working | Fix according to state | @Asaf Ben-Oved | @Ori Cohen Fixed (31.10.22) |
Done | Icon buttons remaining in hover state when we mouse off. | @Ethan McGonigle (Unlicensed) | @Ori Cohen Works fine | |
Done | In prototype mode, a clicking on a dropdown opens the menu but it disturbs the pop-up. I’m not sure where is the problem, but these are both Figma components which I didn’t apply any interaction on see recording | Either remove the click-to-open a menu or check to see what is the cause of problem. | @Asaf Ben-Oved | @Ori Cohen Fixed (31.10.22) |
Done | The wizard dialog includes OK and Cancel buttons | Will include the Next and Back buttons | @Ayelet Servi | @Ori Cohen Fixed (31.10.22) |
Done | Slider doesn’t have a disabled state | Add | @Ayelet Servi | @Ori Cohen Fixed (31.10.22) |
Done | Slider state dropdown mixes states like disabled, enabled, focused with the full/half/empty states | Separate the two so we can have, for example, a full disabled slider | @Ayelet Servi | Hi @Ayelet Servi, these variants have been added 😊 |
Done | Wizard stages - I can’t find an easy way to change the status of the circles (Completed, current, future. not sure if these are the best names) | Add a status dropdown like in other components | @Ayelet Servi | Solved. (08.11.22) |
Done | Selectors are fine when the first node is the one selected. However, switching the second one to Selected and the first to Regular results in missing borders | Result:
| @Carlie Bradshaw | Hi @Carlie Bradshaw, this has been resolved and updated. |
Done | Drop down component (single selection) stays open after we select a value or click outside. (Example swapping between 2 modals) | The dropdown will automatically close after we select a value. | @Ayelet Servi @Carlie Bradshaw | Hi @Carlie Bradshaw, here’s the example I was referring to in the comment thread: |
Done | Please add the empty state to Search with AutoSuggest
|
| @Asaf Ben-Oved | Hi@Asaf Ben-Oved, done! |
Done | Missing the Searchable Multi-select drop down option . currently it only supports Searchable Single-select | Please add this | @Asaf Ben-Oved | Hi @Asaf Ben-Oved, the multi-select dropdown and searchable multi-select dropdown variants have been added 👍 |
Done | Fillable text fields/areas | I have no idea if this is even possible in figma, but it’d be real nice if the user could actually enter text into text fields in prototypes? | @Carlie Bradshaw | @Carlie Bradshaw Unfortunately not yet but the feature request has a fair amount of votes on their forum - https://forum.figma.com/t/interactive-text-inputs-in-prototype-mode/366/29 |
Done | Annotation position order
| please set the order as
So it makes some mapping between the text position in the menu and where the text bubble will appear | @Asaf Ben-Oved | Hi @Asaf Ben-Oved Now fixed! |
Done | Mouse cursor icons. In the Sketch library there was a set of mouse cursors that was built for the UX (as I remember). I don’t see these icons now. For example, when dragging an object the mouse cursor change to a gripping hand | Move the set of mouse cursors from Sketch to the Figma library | @Asaf Ben-Oved | @Asaf Ben-Oved Done. |
Done | The background of the popover is transparent. | Change to opaque (as default). | @Ayelet Servi | @Ayelet Servi Done 👍 |
Done | For the “popup” asset - the combination of Dialog-General-Large is not allowed | Allow | @Ayelet Servi | @Ayelet Servi Added 😊 |
Done | Dual list selector - the name “Selected columns” is different from the name in the documentation (“Chosen columns”) | As far as I understand the name should be changed to “Chosen columns”, so as not to confuse with the selection done with the checkboxes. | @Ayelet Servi | Hi @Ayelet Servi, this has been updated 😊 |
Done | Please fix title position. see screen video
|
| @Asaf Ben-Oved | @Asaf Ben-Oved Fixed! |
Done | The wizard asset - When we stretch it the padding between the buttons and the right side of the dialog gets larger and larger (relatively to the dialog’s size).
| I think that the padding should stay fixed. | @Ayelet Servi | @Ayelet Servi Fixed! |
Done | Allow pop-over to put the arrow in all directions and. not just to the left |
| @Asaf Ben-Oved | @Ethan McGonigle (Unlicensed) Will reuse the same technique applied in annotations. |
Done | Time Picker icon name incorrect | Labelled ‘Regular/ime Picker copy’. Missing T makes it hard to find, and not sure why it’s a copy. | @Carlie Bradshaw | @Carlie Bradshaw Should be fixed now |
Done | List with two rows uses the wrong styling see picture
|
| @Asaf Ben-Oved | Hi @Asaf Ben-Oved, these issues have been fixed - should all work/look as intended now. |
Done | Tree asset - For some reason when I moved branches to be third level they changed their background to white:
| Same transparent background as the rest | @Ayelet Servi | @Ayelet Servi We’ve tested and couldn’t replicate the bug. Can you verify and let us know please? @Femi @Ethan McGonigle (Unlicensed) - I can’t replicate it either now. Please ignore and if it happens again I’ll report.
|
Done | Icon button - For some reason, after I replace the original icon with the icon I want, the option to change it’s properties disappears. | Fix please. | @Ayelet Servi | @Ayelet Servi We’ve tested and couldn’t replicate the bug. Can you verify and let us know please? NOTE: You have to be on the correct instance in your layers for the properties to show up. @Femi @Ethan McGonigle (Unlicensed) - I’ll be happy to show you. Hi @Ayelet Servi, we’ve added the ability to swap icons in the component properties now as well, so no need to do this via the layers anymore 😊. |
Done | I miss 2 states in the date picker:
|
| @Liat Vax | Hi @Liat Vax, added 😊. |
Done | Small switch/toggle button with text isn’t aligned correctly in files. | It’s odd. It looks fine in the LUX figma file, but copying or adding to another file causes the text to be misaligned. Demos of problem:
| @Carlie Bradshaw | Hi @Carlie Bradshaw, thanks for the demos! Fixed 😊 |
Done | Dropdowns don’t have read only state |
| @Liat Vax | Hi @Liat Vax, this is intentional 😊, the relevant dropdown menu states can be seen here - https://kanasoftware.jira.com/wiki/spaces/UserExp/pages/659358568/Drop-down+Menu#States. |
Done | ‘Tag’ icon doesn’t resize | Container size changes but actual vector doesn’t. NB: ‘Tags’ icon (plural) resizes fine. | @Carlie Bradshaw | Hi @Carlie Bradshaw, fixed. |
Done | Errant line in Copy icon | The left-hand line shouldn’t extend to the bottom (according to the LUX iconography page). | @Carlie Bradshaw | Hi @Carlie Bradshaw, I noticed this as well! Thanks for the iconography page reference to verify the correct vector. Fixed. |
Done | The tree component does not let us add lines to it | Add hidden lines | @Ayelet Servi | Fixed. |
Done | Add an instance to the pop over component so the content can be swapped
| Add an instance | @Asaf Ben-Oved | @Asaf Ben-Oved give it a try. |
Done | Toggle / switch text alignment is broken on small size
| Needs to be fixed | @Femi | Hi @Femi , that’s werid.. |
Done | Toggle - vertical text alignment | Solve the alignment | @Shiri Klein Somberg (on behalf of @Guy Hivroni (Unlicensed)) | @Shiri Klein Somberg , @Guy Hivroni (Unlicensed) Fixed and fixed :) |
Done | Radio buttons internal dot not the same size as in zeplin | Align with Zeplin design | @Femi | @Ori Cohen 25.6.23 |
Done | Bug in confirmation messages with the buttons. When hovering over the buttons this happens: |
| @Ayelet Servi | @Ori Cohen Fixed |
Done | Tooltip, | should be modified as 28 px height and find the right frame paddings. | @Itay lapid (Unlicensed) |
|
Done | Can’t add more than 5 primary tabs | Can’t add any more than the given 5 without detaching. (Don’t think there’s any LUX guidance saying you can’t have >5) | @Carlie Bradshaw | Fixed (19.09.23) Added 5 more @Carlie Bradshaw |
Done | Dropdown changes text content when we change its state. | The text will not change. | @Ayelet Servi | Fixed (19.09.23) @Ayelet Servi |
Done | When adding a text field and switching to Read Only, the text color is #666 instead of #333 (see Zeplin). | Update the Filled, Read Only state text to #333. | @Liav Nadler | Assigned to @Hasitha Jayarathne In Zepling Read Only text color is not #333 it’s #666. |
Done | Add read-only checkbox | Add read-only checkbox | @Ori Cohen | Is that the correct design? |
Done | Text color in readonly (textfields etc) not black enough according to Guy Add 'readonly states for drop down (even though not supported in html) | Check Zeplin | @Femi | I’m trying to understand how we want to approach the first part. |
Done | Update components read-only font color and add read-only states to components missing them | Make sure all Figma library elements use the right read-only colors | @Shiri Klein Somberg (on behalf of @Guy Hivroni (Unlicensed) and @Asaf Ben-Oved) | @Itay lapid (Unlicensed) looking into this |
Done | Probably need to have menu ‘group headers’ added as a component. Documented in the following places: https://kanasoftware.jira.com/wiki/spaces/UserExp/pages/918917536 | Could possibly be added the same way as menu dividers within the ‘1. Option Item’ object…
Figma example can be found in the following file ('Other Examples') page: | @Stephen Folkes | @Femi I remember Ethan and I worked on this one. @Ori Cohen Sorry this one was actually already done. I just forgot to mark it as done here and move it to completed |